GitLab de la Mairie de Villejuif

  1. 12 Jul, 2015 1 commit
  2. 11 Jul, 2015 1 commit
  3. 24 Jun, 2015 2 commits
  4. 07 Jun, 2015 2 commits
  5. 05 Jun, 2015 2 commits
  6. 28 May, 2015 2 commits
  7. 27 May, 2015 1 commit
  8. 19 May, 2015 2 commits
  9. 16 May, 2015 1 commit
  10. 12 May, 2015 1 commit
  11. 08 May, 2015 1 commit
  12. 06 May, 2015 2 commits
  13. 26 Apr, 2015 1 commit
  14. 22 Apr, 2015 2 commits
  15. 21 Apr, 2015 1 commit
  16. 17 Apr, 2015 2 commits
  17. 16 Apr, 2015 1 commit
    • yharsh's avatar
      Using e.ctrlKey inplace of keys[17]. · 8440cb29
      yharsh authored
      Problem: Terminal become unresponsive when browser short-cuts are keyed in.
      
      Ctrl + l clears terminal and moves focus to location bar in browser (firefox).
      After keying this short-cut terminal will not show any output even if user presses any key till he/she press Ctrl key alone.
      Similar behavior is observed with Ctrl + [b, B, o, j, A, s, S, f, k, K,  d, D, b, I, e, E , f4, n, P, tab, T, N, sht + del] etc.
      
      Problem Analysis: When Ctrl is pressed in combination with other key(s) then key up event is fired for the key which is released first. For example if Ctrl + l is pressed and l is released first then key-up event will be fired for l key not for Ctrl key. So keys[17] will not be deleted and the next key-press is treated as pressed with Ctrl key(sends as "keyCode" not as "command). But when Ctrl is pressed alone and released, it deletes keys[17] and hence terminal works again.
      
      Fix: Instead of relying on keys[17] for checking combination with Ctrl key we should use e.ctrlKey. Same can be done for alt key, keys[18] should be replaced with e.altKey where e is the event.
      8440cb29
  18. 10 Apr, 2015 1 commit
  19. 09 Apr, 2015 1 commit
  20. 08 Apr, 2015 2 commits
  21. 29 Mar, 2015 1 commit
  22. 28 Mar, 2015 2 commits
  23. 21 Mar, 2015 1 commit
  24. 20 Mar, 2015 2 commits
  25. 19 Mar, 2015 1 commit
  26. 15 Mar, 2015 1 commit
  27. 13 Mar, 2015 3 commits